Skip to content
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.

Renamed install_plugin definition to prevent conflict #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jujugrrr
Copy link

@jujugrrr jujugrrr commented Nov 3, 2014

Hi,
I've tried to use the newrelic_plugin and it worked well. However As soon I've added an other cookbook(elasticsearch) to my metadata it failed.

It's coming from a conflict between the definition install_plugin in newrelic_plugin_chef and the install_plugin method from elasticsearch cookbook.

recipes/mysql.rb was trying to install a plugin but it was actually calling the elasticsearch method, therefore I got errors like this :

Chef::Exceptions::ResourceNotFound:
       resource ruby_block[Install plugin: newrelic_mysql_plugin] is configured to notify resource service[elasticsearch] with action restart, but service[elasticsearch] cannot be found in the resource collection. ruby_block[Install plugin: newrelic_mysql_plugin] is defined in /var/folders/0p/l33795bn35ng4f_6p_7sqtbm2tcccx/T/d20141103-22587-13abh3b/cookbooks/elasticsearch/libraries/install_plugin.rb:35:in `install_plugin'

I've not been able to find a better solution than to rename the definition in newrelic_plugins_chef. It's a small change, and should prevent any further conflict.

It's a big blocker for us, and I guess it would be for other people too.

Thank you!

@martinb3
Copy link

martinb3 commented Nov 3, 2014

👍 install_plugin is very, very generic.

@prometheanfire
Copy link
Contributor

👍

@jujugrrr
Copy link
Author

jujugrrr commented Jan 6, 2015

Hello, could we have an update on this PR?

@martinb3
Copy link

Any update on this? @jstenhouse ?

@martinb3
Copy link

Any updates?

@BackSlasher
Copy link

This is so simple to fix and so annoying to encounter! @jstenhouse sorry to pester you but what's NewRelic's policy for merging? Why is this still open?

@jujugrrr
Copy link
Author

jujugrrr commented Nov 9, 2015

@BackSlasher we are using this for now => https://github.com/rackspace-cookbooks/newrelic_plugins_chef. There is no commit since last year, so not much to maintain on the fork

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants